Hi Krzysztof,
> From: Krzysztof Kozlowski, Sent: Friday, October 21, 2022 9:50 AM
>
> On 19/10/2022 04:34, Yoshihiro Shimoda wrote:
> > Document Renesas Etherent SERDES for R-Car S4-8 (r8a779f0).
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > ---
> > .../phy/renesas,r8a779f0-ether-serdes.yaml | 54 +++++++++++++++++++
> > 1 file changed, 54 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/phy/renesas,r8a779f0-ether-serdes.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/phy/renesas,r8a779f0-ether-serdes.yaml
> b/Documentation/devicetree/bindings/phy/renesas,r8a779f0-ether-serdes.yaml
> > new file mode 100644
> > index 000000000000..ea392cd6e947
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/renesas,r8a779f0-ether-serdes.yaml
> > @@ -0,0 +1,54 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
<snip>
> > +$schema:
<snip>
> > +
> > +title: Renesas Ethernet SERDES
> > +
> > +maintainers:
> > + - Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > +
> > +properties:
> > + compatible:
> > + const: renesas,r8a779f0-ether-serdes
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + resets:
> > + maxItems: 1
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + '#phy-cells':
> > + description: Port number of SERDES.
> > + const: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > + - resets
> > + - power-domains
> > + - '#phy-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/r8a779f0-cpg-mssr.h>
> > + #include <dt-bindings/power/r8a779f0-sysc.h>
> > +
> > + serdes@e6444000 {
>
> Phy devices are usually named "phy" and you use it as a phy device. As
> serdes I guess you refer to actual hardware implementation, but still
> the role is phy, isn't it?
You're correct. I'll fix the name.
> > + compatible = "renesas,r8a779f0-ether-serdes";
>
> Use 4 spaces for example indentation.
Oops! I'll fix the indentation.
Best regards,
Yoshihiro Shimoda
> > + reg = <0xe6444000 0xc00>;
> > + clocks = <&cpg CPG_MOD 1506>;
> > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> > + resets = <&cpg 1506>;
> > + #phy-cells = <1>;
> > + };
>
> Best regards,
> Krzysztof
