On 2022-10-20 09:30, Parikshit Pareek wrote:
Introduce the Qualcomm SA8540P ride automotive platform, also known as
Qdrive-3 development board.
This initial contribution supports SMP, CPUFreq, cluster idle, UFS,
RPMh
regulators, debug UART, PMICs, remoteprocs and USB.
The SA8540P ride contains four PM8450 PMICs.
Signed-off-by: Parikshit Pareek <quic_ppareek@xxxxxxxxxxx>
---
Hi!
[...[
+ vreg_l3c: ldo3 {
+ regulator-name = "vreg_l3c";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
Not sure if setting load is desired after recent rpmh regulator changes.
[...]
+
+&spmi_bus {
+ pm8450a: pmic@0 {
+ compatible = "qcom,pm8150", "qcom,spmi-pmic";
Please add a pm8450[aceg].dtsi instead, as other boards would probably
like to
reuse this. Also, move the spmi.h inclusion there.
[...]
+};
+
+/* PINCTRL */
Not sure if it's useful if there's nothing there for now.
Konrad
