Hi, On 10/21/2014 10:29 PM, Hans de Goede wrote: > Hi, > > On 10/21/2014 06:21 PM, Dmitry Torokhov wrote: >> Hi Hans, >> >> On Tue, Oct 21, 2014 at 10:24:49AM +0200, Hans de Goede wrote: >>> + button@98 { >>> + label = "Home"; >>> + linux,code = <KEY_HOME>; >> >> I do not think you really want KEY_HOME (go to the beginning of the >> line) here, KEY_HOMEPAGE or similar would suit better. > > I can understand where you're coming from, but KEY_HOME is what these > keys typically send under android, and what android expects them to > send... > > Not sure if that is a good argument to keep it as KEY_HOME though. > > Please let me know which way you want this key to be mapped, and > I'll update it for the next version. Sleeping a night on this I fully agree that what android is doing / expecting here is just plain wrong, so I'll change this to KEY_HOMEPAGE when I respin the set. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html