Re: [PATCH v3] arm64: dts: mt8195: Add Ethernet controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 20/10/22 04:41, Biao Huang ha scritto:
Add Ethernet controller node for mt8195.

Signed-off-by: Biao Huang <biao.huang@xxxxxxxxxxxx>
---
  arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 88 ++++++++++++++++++++
  arch/arm64/boot/dts/mediatek/mt8195.dtsi     | 88 ++++++++++++++++++++
  2 files changed, 176 insertions(+)


..snip..

diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index 905d1a90b406..7efaf92c5ff3 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -1042,6 +1042,94 @@ spis1: spi@1101e000 {
  			status = "disabled";
  		};
+ eth: ethernet@11021000 {
+			compatible = "mediatek,mt8195-gmac", "snps,dwmac-5.10a";

..snip..

+			#address-cells = <0>;
+			#size-cells = <0>;

I'm truly sorry for a partial bad suggestion, you don't need to specify address nor
size cells = <0>; in the ethernet node, or you get a warning:

arch/arm64/boot/dts/mediatek/mt8195.dtsi:1174.26-1260.5: Warning (avoid_unnecessary_addr_size): /soc/ethernet@11021000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

So please remove these two.

After which...

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux