Hi Florian, > From: Florian Fainelli, Sent: Thursday, October 20, 2022 11:23 AM > > On 10/19/2022 1:35 AM, Yoshihiro Shimoda wrote: > > Add Renesas Ethernet Switch driver for R-Car S4-8 to be used as an > > ethernet controller. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > How can this be a switch driver when it does not include any switchdev > header files nor does it attempt to be using the DSA framework? You are > certainly duplicating a lot of things that DSA would do for you like > managing PHYs and registering per-port nework devices. Why? The current driver doesn't support any forwarding offload. And, at the first step of supporting this hardware, I'd like to use the hardware as an ethernet controller for sending/receiving frames. So, I didn't use the switchdev and the DSA frameworks. By the way, the hardware name is "Ethernet Switch" so that I wrote the subject as "Add Ethernet Switch driver". But, I'm thinking that this subject/commit description should be changed like below: --- Subject: net: ethernet: renesas: Add support for "Ethernet Switch" Add initial support for Renesas Ethernet Switch of R-Car S4-8. The hardware has features about forwarding for an ethernet switch device. But, for now, it acts as an ethernet controller so that any forwarding offload features are not supported. --- Best regards, Yoshihiro Shimoda > -- > Florian
