On 19/10/2022 04:35, Yoshihiro Shimoda wrote: > Document Renesas Etherent Switch for R-Car S4-8 (r8a779f0). > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> Thank you for your patch. There is something to discuss/improve. > + ethernet-ports: > + type: object > + additionalProperties: false > + > + properties: > + '#address-cells': > + description: Port number of ETHA (TSNA). > + const: 1 > + > + '#size-cells': > + const: 0 > + > + patternProperties: > + "^port@[0-9a-f]+$": > + type: object > + $ref: /schemas/net/ethernet-controller.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + description: > + Port number of ETHA (TSNA). > + > + phy-handle: true > + > + phy-mode: true Why do you need these two properties here? They are provided by ethernet-controller, so I suggest to drop them. I already commented about it in v3. > + > + phys: > + maxItems: 1 > + description: > + Phandle of an Ethernet SERDES. > + > + mdio: > + $ref: /schemas/net/mdio.yaml# > + unevaluatedProperties: false > + > + required: > + - reg > + - phy-handle > + - phy-mode > + - phys > + - mdio Best regards, Krzysztof
