On Tue, Oct 18, 2022 at 11:22:13AM -0400, Krzysztof Kozlowski wrote: > On 18/10/2022 05:40, Johan Hovold wrote: > > On Mon, Oct 17, 2022 at 01:20:49PM -0400, Krzysztof Kozlowski wrote: > >> On 17/10/2022 10:53, Johan Hovold wrote: > >>> Add bindings for the PCIe QMP PHYs found on SC8280XP. > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml > >> > >> Filename based on compatible, so for example: > >> > >> qcom,sc8280xp-qmp-pcie-phy.yaml > > > > Ok, but as I mentioned in my reply to the previous patch, this file is > > the one that is expected to be extended with new bindings. > > I would still propose to use compatible of this series and treat it as a > family name of compatible or similar devices. What other choice we have? > > If new (third) PHY bindings appear, then rename older to "-legacies" and > this one to "-legacy"? We could also continue using qcom,qmp-pcie-phy.yaml for the latest generic binding were new devices should be added and rename the "deprecated" ones after one of the compatibles to make it sound less generic. But I get your point. > > I can't seem to find where this naming scheme is documented now even if > > I'm quite sure I've seen it before. Do you have a pointer? > > If you need the source of authority, then: > https://lore.kernel.org/linux-devicetree/YlhkwvGdcf4ozTzG@xxxxxxxxxxxxxxxxxx/ > > If you need unofficial documentation, then slides here: > https://osseu2022.sched.com/event/15z0W > > If you need something official, that's on TODO list. :) Heh. Ok. > > And does this imply that the file name should also include the gen infix > > of one of the original compatibles (e.g. > > "qcom,sc8280xp-qmp-gen3x4-pcie-phy.yaml")? > > Since you already have here three compatibles, you cannot have one > filename matching exactly all of them, so we already accept something > generic. Therefore I proposed the common part - matching SoC component. Yeah, that's what I was alluding too. As soon you add one more SoC to the same document, the common part is no longer qcom,sc8280xp-qmp-pcie-phy but rather qcom,qmp-pcie-phy Johan
