On 18/10/2022 09:05, Yinbo Zhu wrote: > This file defines all loongson2 soc clock indexes, it should be > included in the device tree in which there's device using the > clocks. > > Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> > --- > MAINTAINERS | 6 +++++ > include/dt-bindings/clock/loongson2-clock.h | 29 +++++++++++++++++++++ Use subject prefixes matching the subsystem (git log --oneline -- ...). These are bindings. > 2 files changed, 35 insertions(+) > create mode 100644 include/dt-bindings/clock/loongson2-clock.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index a162b6fba6fe..3db469f51d74 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11914,6 +11914,12 @@ S: Maintained > F: Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml > F: drivers/clocksource/loongson2_hpet.c > > +LOONGSON2 SOC SERIES CLOCK DRIVER > +M: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> > +L: linux-clk@xxxxxxxxxxxxxxx > +S: Maintained > +F: include/dt-bindings/clock/loongson2-clock.h > + > LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI) > M: Sathya Prakash <sathya.prakash@xxxxxxxxxxxx> > M: Sreekanth Reddy <sreekanth.reddy@xxxxxxxxxxxx> > diff --git a/include/dt-bindings/clock/loongson2-clock.h b/include/dt-bindings/clock/loongson2-clock.h > new file mode 100644 > index 000000000000..23806408fe49 > --- /dev/null > +++ b/include/dt-bindings/clock/loongson2-clock.h Filename matching the compatible, so: loongson,ls2k-clk.h > @@ -0,0 +1,29 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ Dual license, like bindings, unless you are not allowed. > +/* > + * Author: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> > + * Copyright (C) 2022-2023 Loongson Technology Corporation Limited > + */ > + > +#ifndef __DT_BINDINGS_CLOCK_LOONGSON2_H > +#define __DT_BINDINGS_CLOCK_LOONGSON2_H > + > +#define LOONGSON2_REFCLK_100M 0 Drop weird indentation after define. Best regards, Krzysztof