>> + >> + reg: >> + maxItems: 1 >> + >> + reset-gpios: >> + description: Optional reset line >> + maxItems: 1 >> + >> + reset-duration: >> + description: Reset duration in milliseconds >> + default: 200 > >This is a friendly reminder during the review process. > >It seems my previous comments were not fully addressed. Maybe my >feedback got lost between the quotes, maybe you just forgot to apply it. >Please go back to the previous discussion and either implement all >requested changes or keep discussing them. > >Thank you. > I am documenting "what is" rather than what I think it should be. I would prefer there be a "-ms" suffix on the name, but that was not what was in the pre-existing code. I added the "default: 200" line and can add a "maxItems: 1", but begin getting errors when I attempt to further define this field as a uint32 type or anything like that. And no, I'm not getting any warnings or errors from the dt_bindings_check. I reviewed the v3 comments. The only other thing I missed in v4 was changing the comments from C++ style to C style comments. >> + >> +required: >> + - compatible >> + - reg >> + >Best regards, >Krzysztof > Regards, Jerry.
