On 2022-10-08 15:53, Aurelien Jarno wrote: > On 2022-10-08 14:11, Dan Johansen wrote: > > > > Den 30.09.2022 kl. 07.12 skrev Aurelien Jarno: > > > On the ODROID forum, Dongjin Kim said he is not planning to submit a new > > > version of the patchset adding support for the Hardkernel ODROID-M1 > > > board. I therefore decided to address the issues reported during the > > > initial review, and I also did some small fixes either because some > > > things changed in the meantime on the kernel side or because I noticed > > > some warning or issues when using the hardware. > > > > > > I continued writing some additional patches to complete the ODROID M1 > > > DTS to almost fully support the hardware, the drivers being already > > > present in the kernel. > > > > > > This new version includes feedback from the linux-rockchip mailing list > > > and from the Odroid forum. > > > > > > Changes since v2: > > > * Renamed "Rockchip RK3568 Hardkernel ODROID-M1" into "Hardkernel Odroid > > > M1" and fix the sorting. > > > * Fix sorting of arch/arm64/boot/dts/rockchip/Makefile > > > * Collected Acked-by and Tested-by > > > > Even though I added my Tested-by to this series, it seems I didn't test it > > on eMMC. > > > > This fails to boot for me on eMMC, but works on SD card and NVMe. > > Thanks for the feedback. I do not have an eMMC, so this the only part > from the patchset that I haven't been able to test. > > First of all, which version have you tested? The v2 includes fixes for > the eMMC, there was a conflict with the NOR flash. If the problem is > still there in the v2, could you please send the boot log or the error > message? Sorry I meant v3 above. Anyway in the meantime I have bought an eMMC, and I confirm that: - it does no work with the v2 due to a conflict with the NOR flash driver - it does work with the v3 Therefore can you please retry with the v3? Thanks Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@xxxxxxxxxxx http://www.aurel32.net
