Re: [PATCH] dt-bindings: ti-serdes-mux: Add defines for J784S4 SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15/10/2022 01:50, Matt Ranostay wrote:
> There are 4 lanes in the single instance of J784S4 SERDES. Each SERDES
> lane mux can select up to 4 different IPs. Define all the possible
> functions.
> 
> Signed-off-by: Matt Ranostay <mranostay@xxxxxx>
> ---
>  include/dt-bindings/mux/ti-serdes.h | 62 +++++++++++++++++++++++++++++
>  1 file changed, 62 insertions(+)
> 
> Related patchset series for j784s4 support:
> Link: https://lore.kernel.org/linux-arm-kernel/20221014082314.118361-1-a-nandan@xxxxxx/
> 
> diff --git a/include/dt-bindings/mux/ti-serdes.h b/include/dt-bindings/mux/ti-serdes.h
> index d3116c52ab72..669ca2d6abce 100644
> --- a/include/dt-bindings/mux/ti-serdes.h
> +++ b/include/dt-bindings/mux/ti-serdes.h
> @@ -117,4 +117,66 @@
>  #define J721S2_SERDES0_LANE3_USB		0x2
>  #define J721S2_SERDES0_LANE3_IP4_UNUSED		0x3
>  
> +/* J784S4 */
> +
> +#define J784S4_SERDES0_LANE0_IP1_UNUSED		0x0

You shouldn't store register values in the bindings. It's not their
purpose and there is no single need.

Although pattern already started here, so that's not a problem of this
patch:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux