On 12/10/2022 13:42, Doug Anderson wrote: > Hi, > > On Fri, Oct 7, 2022 at 7:51 AM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> + drive-strength: >> + enum: [2, 4, 6, 8, 10, 12, 14, 16] >> + default: 2 >> + description: >> + Selects the drive strength for the specified pins, in mA. > > The "default" of 2 is not correct. Please see commit 768f8d8e45f9 > ("dt-bindings: pinctrl: drive-strength doesn't default to 2 if > unspecified") Uh, you're right. This was copied to one binding and then I copied to another, and another... > > In fact, are you sure this even needs to be replicated here? This is > part of the common "qcom,tlmm-common.yaml" bindings file, isn't it? If the value was correct, it might be per-SoC specific, but that's another question. The default value is actually unknown, so I'll remove it. Best regards, Krzysztof