On 10/10/2022 11:22 PM, Greg Kroah-Hartman wrote:
On Mon, Oct 10, 2022 at 01:58:00PM -0700, Elliot Berman wrote:
On 10/10/2022 1:23 PM, Greg Kroah-Hartman wrote:
On Sun, Oct 09, 2022 at 01:59:21PM -0700, Elliot Berman wrote:
On 10/7/2022 12:40 AM, Greg Kroah-Hartman wrote:
On Thu, Oct 06, 2022 at 10:59:51PM -0700, Elliot Berman wrote:
"GH" is the shorthand we've been using for "Gunyah". I didn't find
documentation for dynamically assigned char devices, but if it exists, I can
add entry for ttyGH.
Why use a new name at all? Why not stick with the existing tty names
and device numbers?
I can use hvc framework, although driver-level buffering is needed on
both the get_chars/put_chars paths because:
I'm not asking about the framework (although that is a good question,
you need to document why this has to be new.) I'm asking why pick a new
name? You will not have a name conflict in your system with this device
with any other tty name right?
That's correct, I didn't see any other instances of "ttyGH" in kernel.
Do you see any instances of ttyS? Any other existing name? Why pick a
new name at all?
And if you do pick a new name, you need to document it really really
well, not bury it downn within the tty driver code.
Seems other drivers are adding a comment in Kconfig help text. I can do
the same.
