On Fri, 30 Sep 2022 13:37:28 +0100, Conor Dooley wrote: > On Fri, Sep 30, 2022 at 08:23:18PM +0800, Hal Feng wrote: > > Add Kconfig options to select the specified StarFive SoC. Select > > necessary Kconfig options required by the specified SoC for booting. > > > > Signed-off-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxxxxxxxx> > > --- > > arch/riscv/Kconfig.socs | 27 ++++++++++++++++++++++++++- > > arch/riscv/boot/dts/starfive/Makefile | 4 ++-- > > drivers/clk/starfive/Kconfig | 14 ++++++-------- > > drivers/pinctrl/starfive/Kconfig | 6 ++---- > > drivers/reset/Kconfig | 1 - > > Firstly, you cannot change all of these files in one commit, sorry. > > > 5 files changed, 36 insertions(+), 16 deletions(-) > > > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs > > index 10f68a4359f9..321c448e7b6f 100644 > > --- a/arch/riscv/Kconfig.socs > > +++ b/arch/riscv/Kconfig.socs > > @@ -22,10 +22,35 @@ config SOC_STARFIVE > > bool "StarFive SoCs" > > select PINCTRL > > select RESET_CONTROLLER > > + select RESET_STARFIVE > > Secondly, we are trying to get rid of selects in arch/riscv at the > moment, not add them. use "default SOC_STARFIVE" in > drivers/reset/kconfig instead please. > > > + help > > + This enables support for StarFive SoC platform hardware. > > + > > +if SOC_STARFIVE > > I don't think we want to have per soc selection menus in arch code, > I think this should move to drivers/soc (a la Renesas) if you want to > have a per soc selection menu or else just do "default SOC_STARFIVE" > for both clock and pinctrl drivers in the clk and pinctrl Kconfig > entries. Thanks for your helpful comments. I will drop this patch. Best regards, Hal
