On 11/10/2022 05:30, Alexandre Mergnat wrote: > Hi Krzysztof, > > Thanks for your review ! > > >> + > >> + properties: > >> + regulator-name: > >> + pattern: "^v(core|modem|pa|proc|s1)$" > > > > Why enforcing particular name of the regulator? > > The regulator names are forced to match with the datasheet names. > > I think it's a good practice to increase visibility between HW & SW. Enforcing is not a good practice. > > Also, that keep consistency with other Mediatek PMIC schema. So there is a bad practice and instead of fixing it, you align to it... No. Best regards, Krzysztof
