On Sun, Oct 09, 2022 at 01:33:51PM +0100, Jonathan Cameron wrote: > On Thu, 6 Oct 2022 21:32:11 +0300 > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Thu, Oct 06, 2022 at 05:38:14PM +0300, Matti Vaittinen wrote: ... > > > +module_param(g_kx022a_use_buffer, bool, 0); > > > +MODULE_PARM_DESC(g_kx022a_use_buffer, > > > + "Buffer samples. Use at own risk. Fifo must not overflow"); > > > > Why?! We usually do not allow module parameters in the new code. > > Badly broken hardware - was my suggestion. Alternatives if there are usecases > that need to use the fifo, but it can wedge hard in a fashion that is impossible > to prevent from the driver? My gut feeling is still drop the support entirely > with a strong comment in the code that the hardware is broken in a fashion we don't > know how to work around. I also would drop this from upstream and if anybody curious, provide some kind of GitHub gist for that. Also it needs some communication with a vendor to clarify the things. -- With Best Regards, Andy Shevchenko
