On 08/10/2022 20:51, Colin Foster wrote:
> The ocelot-ext driver is another sub-device of the Ocelot / Felix driver
> system. It requires a register array similar to the VSC7514 and has
> different ports layout than existing devices.
>
Thank you for your patch. There is something to discuss/improve.
> @@ -54,9 +54,24 @@ description: |
> - phy-mode = "1000base-x": on ports 0, 1, 2, 3
> - phy-mode = "2500base-x": on ports 0, 1, 2, 3
>
> + VSC7512 (Ocelot-Ext):
> +
> + The Ocelot family consists of four devices, the VSC7511, VSC7512, VSC7513,
> + and the VSC7514. The VSC7513 and VSC7514 both have an internal MIPS
> + processor that natively support Linux. Additionally, all four devices
> + support control over external interfaces, SPI and PCIe. The Ocelot-Ext
> + driver is for the external control portion.
> +
> + The following PHY interface types are supported:
> +
> + - phy-mode = "internal": on ports 0, 1, 2, 3
> + - phy-mode = "sgmii": on ports 4, 5, 7, 8, 9, 10
> + - phy-mode = "qsgmii": on ports 4, 5, 6, 7, 8, 10
> +
> properties:
> compatible:
> enum:
> + - mscc,vsc7512-switch
> - mscc,vsc9953-switch
> - pci1957,eef0
>
> @@ -258,3 +273,100 @@ examples:
> };
> };
> };
Blank line
> + # Ocelot-ext VSC7512
> + - |
> + #include <dt-bindings/phy/phy-ocelot-serdes.h>
> +
> + soc@0 {
> + compatible = "mscc,vsc7512";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + reg = <0 0>;
> +
> + ethernet-switch@0 {
Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Best regards,
Krzysztof
