On 07/10/2022 10:17, Krzysztof Kozlowski wrote: >>> >>>> There's some bindings with pinctrl-names for specific states like rockchip/rockchip,dw-hdmi.yaml, >>>> mediatek/mediatek,dpi.yaml, mmc/mtk-sd.yaml or mmc/fsl-imx-esdhc.yaml >>> >>> And? Just because someone did something is not itself an argument. They >>> might have their reasons. If their reasons are applicable here, please >>> state them. >> >> OK, I thought the reason was explicit, we find it worth documenting >> those optional pinctrl states for when the spi lines are in idle state. >> >> If it's not an enough good reason, we'll drop this patch. > > No one wrote here any reason... The post from Amjad was about DTS usage, > yours about other bindings. Neither of them are reasons. > > Core schema already documents pinctrl states. This can be documented if > it is different than what core checks for, e.g. required or some > specific names are being enforced. Looking at your driver, these seems required. I missed that part in commit msg, because it actually explains these are needed. Then it seems fine, but they should be made required in the bindings. Best regards, Krzysztof
