On 06/10/2022 14:07, Allen-KH Cheng wrote: Thank you for your patch. There is something to discuss/improve. > + - Matthias Brugger <matthias.bgg@xxxxxxxxx> > + > +description: > + The watchdog supports a pre-timeout interrupt that fires > + timeout-sec/2 before the expiry. > + > +allOf: > + - $ref: watchdog.yaml# > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: This is just one enum in "items", so no need for the "items". > + - mediatek,mt2712-wdt > + - mediatek,mt6589-wdt > + - mediatek,mt7986-wdt > + - mediatek,mt8183-wdt > + - mediatek,mt8186-wdt > + - mediatek,mt8192-wdt > + - mediatek,mt8195-wdt Best regards, Krzysztof