On Mon, 2022-10-03 at 11:38 -0500, Rob Herring wrote: > On Fri, Sep 30, 2022 at 10:57:01PM +0800, Trevor Wu wrote: > > Add document for mt8188 board with mt6359. > > > > Signed-off-by: Trevor Wu <trevor.wu@xxxxxxxxxxxx> > > --- > > .../bindings/sound/mt8188-mt6359.yaml | 70 > > +++++++++++++++++++ > > 1 file changed, 70 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/mt8188- > > mt6359.yaml > > > > diff --git a/Documentation/devicetree/bindings/sound/mt8188- > > mt6359.yaml b/Documentation/devicetree/bindings/sound/mt8188- > > mt6359.yaml > > new file mode 100644 > > index 000000000000..57c7c5ceef8a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/mt8188-mt6359.yaml > > @@ -0,0 +1,70 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > > https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mt8188-mt6359.yaml*__;Iw!!CTRNKA9wMg0ARbw!wMc6I2aXRzI45UPQTEAzU4ZujV6VaiFGkiKBy18A_5DlQehTxU00u1QSpiOzgAgKtA$ > > > > +$schema: > > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!wMc6I2aXRzI45UPQTEAzU4ZujV6VaiFGkiKBy18A_5DlQehTxU00u1QSpiMSKPWbtQ$ > > > > + > > +title: MediaTek MT8188 ASoC sound card driver > > + > > +maintainers: > > + - Trevor Wu <trevor.wu@xxxxxxxxxxxx> > > + > > +description: > > + This binding describes the MT8188 sound card. > > + > > +properties: > > + compatible: > > + enum: > > + - mediatek,mt8188-sound > > + > > + model: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: User specified audio sound card name > > + > > + audio-routing: > > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > > + description: > > + A list of the connections between audio components. Each > > entry is a > > + sink/source pair of strings. Valid names could be the input > > or output > > + widgets of audio components, power supplies, MicBias of > > codec and the > > + software switch. > > + > > + mediatek,platform: > > + $ref: "/schemas/types.yaml#/definitions/phandle" > > Don't need quotes. Hi Rob, Which one are you expected? 1. remove the line 2. $ref: /schemas/types.yaml#/definitions/phandle > > > + description: The phandle of MT8188 ASoC platform. > > + > > + mediatek,dptx-codec: > > + $ref: "/schemas/types.yaml#/definitions/phandle" > > + description: The phandle of MT8188 Display Port Tx codec node. > > + > > + mediatek,hdmi-codec: > > + $ref: "/schemas/types.yaml#/definitions/phandle" > > + description: The phandle of MT8188 HDMI codec node. > > + > > + mediatek,dai-link: > > + $ref: /schemas/types.yaml#/definitions/string-array > > + description: > > + A list of the desired dai-links in the sound card. Each > > entry is a > > + name defined in the machine driver. > > Names have to be defined here. > OK, I will add enum here for listing all available dai-links. Thanks, Trevor > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > + - mediatek,platform > > + > > +examples: > > + - | > > + > > + sound: mt8188-sound { > > + compatible = "mediatek,mt8188-sound"; > > + mediatek,platform = <&afe>: > > + pinctrl-names = "default"; > > + pinctrl-0 = <&aud_pins_default>; > > + audio-routing = > > + "Headphone", "Headphone L", > > + "Headphone", "Headphone R", > > + "AIN1", "Headset Mic"; > > + }; > > + > > +... > > -- > > 2.18.0 > > > >
