Re: [PATCH 1/2] ASoC: dt-bindings: add pin-switches to audio-graph-card2.yaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/10/2022 16:27, Claudio Cabral wrote:
> Document support for pin-switches in audio-graph-card2

Full stop?

> this devicetree property behaves the same way as its homonym in
> simple-card

Missing capital letter and full stop?

Instead please describe why do you need pin-switches in this binding...

> 
> Reviewed-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
> Signed-off-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>

Authorship or contributions (SoB) usually means someone reviewed it and
there is no need for both tags. The combination of both tags above is a
bit surprising.

> Signed-off-by: Claudio Cabral <clca@xxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++
>  1 file changed, 3 insertions(+)

Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux