On 05/10/2022 10:43, Delphine_CC_Chiu/WYHQ/Wiwynn wrote: >> On 20/09/2022 09:45, Bonnie Lo/WYHQ/Wiwynn wrote: >>> Hi Krzysztof, >>> >>> I revise the device tree as following and resend the mail. >>> It create a new mail thread " [PATCH] ARM: dts: aspeed: greatlakes: Add >> Facebook greatlakes (AST2600) BMC". >>> Kindly to correct me, if there is any problem. >>> >>>> Use subject prefixes matching the subsystem (git log --oneline -- ...). >>>> >>>>> >>>>> Add linux device tree entry related to greatlakes specific devices >>>>> connected to BMC SoC. >>>> >>>> Please wrap commit message according to Linux coding style / >>>> submission >>>> process: >>>> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Feli >>>> >> xir.b%2F&data=05%7C01%7CBonnie_Lo%40wiwynn.com%7Ca2eecb3c2d >> ff4eff >>>> >> 361b08da9ae190fd%7Cda6e0628fc834caf9dd273061cbab167%7C0%7C0%7C6 >> 379925 >>>> >> 90848633103%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI >> joiV2luM >>>> >> zIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MJn >> u2iv19 >>>> dvbcMH7SJSExKOFV18dUtGRFSKO6Au2tFg%3D&reserved=0 >>>> >> ootlin.com%2Flinux%2Fv5.18-rc4%2Fsource%2FDocumentation%2Fprocess%2 >>>> >> Fsubmitting-patches.rst%23L586&data=05%7C01%7CBonnie_Lo%40wiw >>>> >> ynn.com%7C1dee8dcb540a49522fb608da98cdba6f%7Cda6e0628fc834caf9dd >>>> >> 273061cbab167%7C0%7C0%7C637990306620286314%7CUnknown%7CTWFp >>>> >> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI >>>> >> 6Mn0%3D%7C3000%7C%7C%7C&sdata=mC2E3dJbuYgXklS%2Fw8s2w%2 >>>> BKH%2BZ3CsZSndFTgPBjyvpw%3D&reserved=0 >>>> >>> >>> I have add " ARM: dts: aspeed: greatlakes:". >>> >>>>> >>>>> Signed-off-by: Bonnie Lo <Bonnie_Lo@xxxxxxxxxx> >>>>> --- >>>>> arch/arm/boot/dts/Makefile | 1 + >>>>> .../dts/aspeed-bmc-facebook-greatlakes.dts | 248 >>>> ++++++++++++++++++ >>>> >>>> Missing documentation of board compatible (bindings) as first patch. >> >> Why did you ignore it? > > We need to look at this more. There might be something under the Documentation tree. > Could you guide us an example for adding the document? https://lore.kernel.org/all/?q=s%3A%22dt-bindings%3A+arm%3A%22 Fix your email server so it won't add footers making open-source collaboration not possible. You said that this email "contains proprietary or confidential information", therefore it is not suitable for open-source discussions. Best regards, Krzysztof
