On Mon, Oct 3, 2022 at 11:34 PM Rob Herring <robh+dt@xxxxxxxxxx> wrote: > ... > > This doesn't fix all the warnings. These still remain: > > /home/rob/proj/linux-dt/.build-arm64/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb: > pmic@34: indicator: 'color' is a required property > From schema: > /home/rob/proj/linux-dt/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml > /home/rob/proj/linux-dt/.build-arm64/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb: > indicator: $nodename:0: 'indicator' does not match > '^multi-led(@[0-9a-f])?$' > From schema: > /home/rob/proj/linux-dt/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml Hi Rob, In my opinion, the root cause of these warnings is the incorrect usage of 'allOf' in our LED indicator dts as follows, (https://lore.kernel.org/all/27df85c30277a171ae85ff6d5b7d867625765d0a.1663926551.git.chiaen_wu@xxxxxxxxxxx/) ---------- +allOf: + - $ref: leds-class-multicolor.yaml# + +properties: + compatible: + const: mediatek,mt6370-indicator + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^multi-led@[0-3]$": + type: object ---------- and this patch for Linux 6.0 (https://lore.kernel.org/all/20220624112106.111351-1-krzysztof.kozlowski@xxxxxxxxxx/) I will revise our LED indicator dts in the next version(v13) of 'MT6370 patch series' like this, ---------- // Remove 'allOf' +properties: + compatible: + const: mediatek,mt6370-indicator + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^multi-led@[0-3]$": + type: object + $ref: leds-class-multicolor.yaml# // Add this line + unevaluatedProperties: false // Add this line ---------- And this '[PATCH v2] dt-bindings: mfd: mt6370: fix the interrupt order of the charger in the example' patch is for fix charger example in MFD dts. Thank you so much. -- Best Regards, ChiaEn Wu
