On 04/10/2022 15:42, Leonard Göhrs wrote: > Add binding documentation for the TI LMP92064 dual channel SPI ADC. Subject: missing spaces after ':'. Also drop "documentation" - kind of redundant. > > Signed-off-by: Leonard Göhrs <l.goehrs@xxxxxxxxxxxxxx> > --- > .../bindings/iio/adc/ti,lmp92064.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,lmp92064.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,lmp92064.yaml b/Documentation/devicetree/bindings/iio/adc/ti,lmp92064.yaml > new file mode 100644 > index 0000000000000..b7b5761baa108 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/ti,lmp92064.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/ti,lmp92064.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments LMP92064 Precision Current and Voltage Sensor. > + > +maintainers: > + - Leonard Göhrs <l.goehrs@xxxxxxxxxxxxxx> > + > +description: | > + The LMP92064 is a two channel ADC intended for combined voltage and current > + measurements. > + > + The device contains two ADCs to allow simultaneous sampling of voltage and > + current and thus of instantanious power consumption. Not sure if my spell-check misses a word or you meant "instantaneous"? > + Missing allOf:$ref to spi-peripheral-props.yaml > +properties: > + compatible: > + enum: > + - ti,lmp92064 > + > + reg: > + maxItems: 1 > + > + spi-max-frequency: true > + > + shunt-resistor: This is not a valid property name. git grep shunt-resistor > + description: | > + Value of the shunt resistor (in µΩ) connected between INCP and INCN, > + across which current is measured. Used to provide correct scaling of the > + raw adc measurement. s/adc/ADC/ > + > + reset-gpios: > + maxItems: 1 > + Best regards, Krzysztof
