Re: [PATCH v4 2/2] dt-bindings: mips: brcm: convert Broadcom SoCs to schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

On Sat, Oct 1, 2022 at 11:47 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 01/10/2022 06:38, Sergio Paracuellos wrote:
> > Convert Broadcom cable/DSL/settop platforms to YAML schema.
>
> Where is the conversion? Conversion is remove+add, but there is no
> removal here.

True, removal is in the other patch since removed doc it is more
related with CPUs.
Will redo this commit message.

>
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> > ---
> >  .../devicetree/bindings/mips/brcm/soc.yaml    | 110 ++++++++++++++++++
> >  1 file changed, 110 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mips/brcm/soc.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mips/brcm/soc.yaml b/Documentation/devicetree/bindings/mips/brcm/soc.yaml
> > new file mode 100644
> > index 000000000000..0ddf1fe51802
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mips/brcm/soc.yaml
> > @@ -0,0 +1,110 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mips/brcm/soc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Broadcom cable/DSL/settop platforms Device Tree Bindings
>
> Drop "Device Tree Bindings"

Understood.

>
> > +
> > +maintainers:
> > +  - Hauke Mehrtens <hauke@xxxxxxxxxx>
> > +  - Rafał Miłecki <zajec5@xxxxxxxxx>
> > +
> > +description: |
> > +    Boards Broadcom cable/DSL/settop SoC shall have the following properties.
> > +    The experimental -viper variants are for running Linux on the 3384's
> > +    BMIPS4355 cable modem CPU instead of the BMIPS5000 application processor.
> > +
> > +properties:
> > +  $nodename:
> > +    const: '/'
>
> Blank line.

Ok.

>
> > +  compatible:
> > +    oneOf:
> > +      - description: Boards with Broadcom bcm3368 SoC
> > +        items:
> > +          - const: brcm,bcm3368
> > +
> > +      - description: Boards with Broadcom bcm3384 SoC
> > +        items:
> > +          - const: brcm,bcm3384
>
> I don't understand what did you want to achieve here. Either you
> document SoC or boards. If boards, where are the actual boards? If SoC,
> then why calling it boards, why making it oneOf?

I agree with description should just say "Broadcom bcm3384 SoC", but I
don't understand what is wrong with oneOf here...

>
>
> > +
> > +      - description: Boards with Broadcom bcm33843 SoC
> > +        items:
> > +          - const: brcm,bcm33843
> > +
> > +      - description: Boards with Broadcom bcm3384-viper SoC
> > +        items:
> > +          - const: brcm,bcm3384-viper
> > +
> > +      - description: Boards with Broadcom bcm33843-viper SoC
> > +        items:
> > +          - const: brcm,bcm33843-viper
> > +
> > +      - description: Boards with Broadcom bcm6328 SoC
> > +        items:
> > +          - const: brcm,bcm6328
> > +
> > +      - description: Boards with Broadcom bcm6358 SoC
> > +        items:
> > +          - const: brcm,bcm6358
> > +
> > +      - description: Boards with Broadcom bcm6362 SoC
> > +        items:
> > +          - const: brcm,bcm6362
> > +
> > +      - description: Boards with Broadcom bcm6368 SoC
> > +        items:
> > +          - const: brcm,bcm6368
> > +
> > +      - description: Boards with Broadcom bcm63168 SoC
> > +        items:
> > +          - const: brcm,bcm63168
> > +
> > +      - description: Boards with Broadcom bcm63268 SoC
> > +        items:
> > +          - const: brcm,bcm63268
> > +
> > +      - description: Boards with Broadcom bcm7125 SoC
> > +        items:
> > +          - const: brcm,bcm7125
> > +
> > +      - description: Boards with Broadcom bcm7346 SoC
> > +        items:
> > +          - const: brcm,bcm7346
> > +
> > +      - description: Boards with Broadcom bcm7358 SoC
> > +        items:
> > +          - const: brcm,bcm7358
> > +
> > +      - description: Boards with Broadcom bcm7360 SoC
> > +        items:
> > +          - const: brcm,bcm7360
> > +
> > +      - description: Boards with Broadcom bcm7362 SoC
> > +        items:
> > +          - const: brcm,bcm7362
> > +
> > +      - description: Boards with Broadcom bcm7420 SoC
> > +        items:
> > +          - const: brcm,bcm7420
> > +
> > +      - description: Boards with Broadcom bcm7425 SoC
> > +        items:
> > +          - const: brcm,bcm7425
> > +
> > +  cpus:
> > +    $ref: "/schemas/mips/cpus.yaml#"
>
> No need for quotes.

Understood.

>
> > +    unevaluatedProperties: false
> > +
> > +    properties:
> > +      mips-hpt-frequency:
> > +        description: This is common to all CPUs in the system so it lives
> > +         under the "cpus" node.
>
> You need to describe what is this. Not where it lives. Because where it
> lives, we can easily see from the schema.

I have just copied this from the previous documented bmips text file. I guess
writing the following will be better:

properties:
      mips-hpt-frequency:
        description: MIPS counter high precision timer frequency.
         This is common to all CPUs in the system so it lives
         under the "cpus" node.
        $ref: /schemas/types.yaml#/definitions/uint32

>
> > +        $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +    required:
> > +      - mips-hpt-frequency
> > +
> > +additionalProperties: true
> > +
> > +...
>
> Best regards,
> Krzysztof
>

Thanks,
    Sergio Paracuellos




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux