On 30/09/2022 17:21, Chris Morgan wrote: >>> +maintainers: >>> + - Chris Morgan <macromorgan@xxxxxxxxxxx> >>> + >>> +allOf: >>> + - $ref: touchscreen.yaml# >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - hynitron,cst3xx >> >> Isn't the panel CST3240? No wildcards in compatibles. >> > > The controller IC I'm using is CST348. This driver SHOULD > also work with a CST340 and a CST356 (untested though). > Whether drivers works or not is rather orthogonal question. What if FreeBSD driver does not work with CST356? What if U-boot driver works with all three and few more? > Should I just have 3 compatible strings then, one for each IC? > I could also just have cst340 as the compatible and note it > should work for the 3 ICs listed. Choose either: 1. The only the one compatible for which you have datasheet or hardware. 2. Choose all three separate compatibles which you believe should have same hardware properties thus one binding fits them (based on experience, datasheet, other drivers). Best regards, Krzysztof