Hi Martin, On So, 2022-09-18 at 11:58 +0200, Martin Povišer wrote: > If a reset domain is attached to the device, obtain a shared reference > to it and trigger it. Typically on a chip the ADMAC controller will > share a reset domain with the MCA peripheral. > > Signed-off-by: Martin Povišer <povik+lin@xxxxxxxxxxx> > --- > drivers/dma/apple-admac.c | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > diff --git a/drivers/dma/apple-admac.c b/drivers/dma/apple-admac.c > index 7d1b76678032..317ca76ccafd 100644 > --- a/drivers/dma/apple-admac.c > +++ b/drivers/dma/apple-admac.c > @@ -12,8 +12,9 @@ > #include <linux/module.h> > #include <linux/of_device.h> > #include <linux/of_dma.h> > -#include <linux/interrupt.h> > +#include <linux/reset.h> > #include <linux/spinlock.h> > +#include <linux/interrupt.h> Moving around the linux/interrupt.h include doesn't belong in this patch. Otherwise this looks good to me, assuming the MCA driver does the same reset/rearm dance. regards Philipp
