Hi Dmitry On 9/29/22 21:13, Dmitry Torokhov wrote: > According to c8sectpfe driver code we first drive reset line low and > then high to reset the port, therefore the reset line is supposed to > be annotated as "active low". This will be important when we convert > the driver to gpiod API. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > --- > arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi > index 2aa94605d3d4..d52a7aaa1074 100644 > --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi > +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi > @@ -178,7 +178,7 @@ tsin0: port { > tsin-num = <0>; > serial-not-parallel; > i2c-bus = <&ssc2>; > - reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>; > dvb-card = <STV0367_TDA18212_NIMA_1>; > }; > }; Reviewed-by: Patrice Chotard <patrice.chotard@xxxxxxxxxxx> Thanks Patrice