Re: [PATCH v5 2/3] dt-bindings: thermal: add loongson2k thermal binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29/09/2022 10:23, Yinbo Zhu wrote:
> 
> 
> 在 2022/9/29 下午3:45, Krzysztof Kozlowski 写道:
>> On 29/09/2022 09:07, Yinbo Zhu wrote:
>>>>>>>
>>>>>>> ... and please test your patches before sending :(
>>>>> You said is refer that "reg: [[0, 534779136], [0, 48]] is too long" ?
>>>>> Need fix that warning, right?
>>>>
>>>> Yes. You said you tested it but then sent with an error... so it's not
>>>> really a testing.
>>> sorry, I did do some testing. but I think It is okay that can generate a
>>> dtb  without reporting an error when compile yaml file, in fact, I
>>> ignore the warning,  I will fix it in v6.
>>
>>
>> Do you also send the code with warnings reported by GCC? Judging by
>> number of kernel test robot reports, it could be. So just to be very,
>> very clear: do not send any code which generates any warning. For GCC
>> this means W=1 builds.
> I don't find about the warning about GCC when compile yaml file.
> and I dont't know the meaning about W=1, you said about "W=1" is to execute
> following command to compile the yaml, right?

GCC is about your C code. You were sending patches knowing that they
have warnings. It's not good. All warnings must be fixed.

Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux