On Thu, 29 Sept 2022 at 15:02, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 29/09/2022 04:29, Chunyan Zhang wrote: > > Hi Krzysztof, > > > > On Wed, 28 Sept 2022 at 19:31, Krzysztof Kozlowski > > <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >> > >> On 28/09/2022 11:29, Chunyan Zhang wrote: > >>> From: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx> > >>> > >>> Convert the Unisoc gpio controller binding to DT schema format. > >>> > >> > >> > >> Thank you for your patch. There is something to discuss/improve. > >> > >>> diff --git a/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml b/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml > >>> new file mode 100644 > >>> index 000000000000..c0cd1ed9809b > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml > >>> @@ -0,0 +1,70 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>> +# Copyright 2022 Unisoc Inc. > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/gpio/sprd,gpio.yaml# > >> > >> Use compatible as filename, so sprd,sc9860-gpio.yaml > > > > Humm... This is not only for SC9860, also for other IPs, UMS512 as an > > example which added in this patchset. > > > > > Then it's ok. It seems you have also typo in commit subject (Conver). Ah yes -_-||, will fix that. > > Best regards, > Krzysztof >
