On 9/13/22 16:16, Sebastian Reichel wrote: > Hi, > > On Tue, Sep 13, 2022 at 11:12:02AM +0200, Uwe Kleine-König wrote: >> Hello Rob, >> >> On Thu, Sep 01, 2022 at 02:14:55PM -0500, Rob Herring wrote: >>> On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote: >>>> Add "rockchip,rk3588-pwm" compatible string for PWM nodes found >>>> on a rk3588 platform. >>>> >>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> >>>> --- >>>> No driver changes required. >>>> --- >>>> Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>> >>> Running 'make dtbs_check' with the schema in this patch gives the >>> following warnings. Consider if they are expected or the schema is >>> incorrect. These may not be new warnings. >>> >>> Note that it is not yet a requirement to have 0 warnings for dtbs_check. >>> This will change in the future. >> >> Is this a list of *new* warnings, or is the report (somewhat) orthogonal >> to the actual change and you just used the opportunity that someone >> touched the pwm-rockchip binding to point out that there is some cleanup >> to do? >> >>> Full log is available here: https://patchwork.ozlabs.org/patch/ >> >> Hm, that gives me a 404. > > This is an existing problem with the rv1108 binding. > The rk3588 does not have pwm interrupts. Hi, Could you recheck? >From Rockchip RK3588 Datasheet V0.1-20210727.pdf: PWM Support 16 on-chip PWMs(PWM0~PWM15) with interrupt-based operation Programmable pre-scaled operation to bus clock and then further scaled Embedded 32-bit timer/counter facility Support capture mode Support continuous mode or one-shot mode Provides reference mode and output various duty-cycle waveform Optimized for IR application for PWM3, PWM7, PWM11, PWM15 === ARM: dts: rk3288: add the interrupts property for PWM https://github.com/rockchip-linux/kernel/commit/16b7b284618d1652e694f6286f575ce82f5f03e5 Comment: At the moment, we can find the remotectl pwm is needed on box. We can add the property for all PWMs. AFAIK, the pwm driver don't use it but the drivers/input/remotectl/rockchip_pwm_remotectl.c === >From Rockchip RK3568 TRM Part1 V1.1-20210301.pdf 8-bit repeat counter for one-shot operation. One-shot operation will produce N + 1 periods of the waveform, where N is the repeat counter value, and generates a single interrupt at the end of operation Continuous mode generates the waveform continuously, and does not generates any interrupts > > -- Sebastian > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-rockchip
