Re: [PATCH v2] dt-bindings: memory-controller: st,stm32: Split off MC properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/28/22 09:10, Krzysztof Kozlowski wrote:

Hi,

[...]

diff --git a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml
index a1f535cececcc..49243f447eb90 100644
--- a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml
@@ -49,143 +49,6 @@ patternProperties:
    "^.*@[0-4],[a-f0-9]+$":
      type: object
- properties:
-      reg:
-        description: Bank number, base address and size of the device.
-

To be equivalent (and similar to SPI peripherals and controllers) this
should reference st,stm32-fmc2-ebi-props.yaml as well.

After such reference, you can add here unevaluatedProperties:false
(could be same or new patch as it is not related to actual split).

I don't think I understand. I don't see any ref from the controller node to its props in various SPI controllers (even if that would make sense):

next$ git grep qspi-nor-peripheral-props.yaml
Documentation/devicetree/bindings/spi/cdns,qspi-nor-peripheral-props.yaml:$id: http://devicetree.org/schemas/spi/cdns,qspi-nor-peripheral-props.yaml# Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml: - $ref: cdns,qspi-nor-peripheral-props.yaml#

No ref to cdns,qspi-nor-peripheral-props.yaml in Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml

next$ git grep tegra210-quad-peripheral-props
Documentation/devicetree/bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml:$id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad-peripheral-props.yaml# Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml: - $ref: nvidia,tegra210-quad-peripheral-props.yaml#

No ref to nvidia,tegra210-quad-peripheral-props.yaml in Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml

What am I missing here ?



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux