On 26/09/2022 20:37, Aurelien Jarno wrote: > From: Dongjin Kim <tobetter@xxxxxxxxx> > > This patch is to add a device tree for new board Hardkernel ODROID-M1 > based on Rockchip RK3568, includes basic peripherals - > uart/eMMC/uSD/i2c and on-board ethernet. Thank you for your patch. There is something to discuss/improve. > > Signed-off-by: Dongjin Kim <tobetter@xxxxxxxxx> > [aurelien@xxxxxxxxxxx: addressed issues from initial review] > Signed-off-by: Aurelien Jarno <aurelien@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../boot/dts/rockchip/rk3568-odroid-m1.dts | 414 ++++++++++++++++++ > 2 files changed, 415 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index ef79a672804a..12e2ef73fe80 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -66,3 +66,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-rock-3a.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb Mismatched order. Best regards, Krzysztof
