On 27/09/2022 12:17, AngeloGioacchino Del Regno wrote: >>> >> >> Sorry, my bad. I alsways run `make dtbs_check` to confirm dtb with >> bindings. I just think we didn't limit node names in mtk-vodec >> bindings. I will pay attention next time. >> >> >> Since currently the vcodec lat and core nodes are absent from the mtk >> dts, do you think the child node name should be changed to something >> more general (ex: video-codec) in mediatek,vcodec-subdev-decoder >> bindings? > > The video codec is mt8192-vcodec-dec, while the other nodes are describing > the VPU instances (and/or vpu cores)... I'm not sure. > > Krzysztof, please, can you give your opinion on that? > What's the difference between them? I understand parent device is entire block of consisting of multiple processing units? If so, video-codec actually could fit in both places. But feel free to call it a bit different (video-codec-core, video-codec-lat, processing-unit, even something less generic). Sometimes it's tricky to find nice name, so I wouldn't worry too much in that case. Just not "mt8192-vcodec" :) Best regards, Krzysztof
