On 2022-09-27 14:46, Anand Moon wrote:
Hi Chukun,
On Mon, 26 Sept 2022 at 23:31, Chukun Pan <amadeus@xxxxxxxxxx> wrote:
Hi,
On 26-09-22, 06:14, Anand Moon wrote:
+ pcie30_3v3: gpio-regulator {
+ compatible = "regulator-gpio";
+ regulator-name = "pcie30_3v3";
+ regulator-min-microvolt = <100000>;
+ regulator-max-microvolt = <3300000>;
+ gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>;
+ gpios-states = <0x1>;
+ states = <100000 0x0>, <3300000 0x1>;
+ };
This is actually no different from vcc3v3-pcie regulator?
+&pcie30phy {
+ data-lanes = <0 1 2 3>;
+ phy-supply = <&vcc3v3_pi6c_03>;
+ status = "okay";
+};
It seems that there is no need to define additional data-lanes when
the pcie3x1 node is not enabled, and phy-supply seems unnecessary on
this board.
As per the schematic below pice support with 2 regulators
VCC3V3_PCIE (SCT2250FPA)
VCC3V3_PI6C_03 (PI6C557-03 is a spread spectrum clock generator
supporting PCI Express and Ethernet requirements)
Neither of which have anything to do with the phy, which is in the SoC
and runs off VDDA_0V9 and VCCA_1V8, see page 12. VCC3V3_PCIE is the
general power supply for the M.2 socket, which I doubt is supposed to
deliver 100mV when disabled.
(as a side note, is pcie2x1's vpcie3v3-supply as queued in -next
actually correct? AFAICS the other socket is effectively powered
straight from VCC3V3_SYS so shouldn't have needed VCC3V3_PCIE, but at
least it's there now ready for this one)
Robin.
[0] https://dl.radxa.com/rock3/docs/hw/3a/rock3a_v1.3_sch.pdf
Excuse me, can you try the patches I posted? Lspci can recognize
pcie3x2 normally, but I don't have a spare nvme hard drive right
now to test if it works.
No, it did not work on my board, see bool logs.
[0] https://pastebin.com/Lk93VFxg
[ 0.725985] phy phy-fe8c0000.phy.4: lane number 0, val 1
[ 0.726975] phy phy-fe8c0000.phy.4: rockchip_p3phy_rk3568_init: lock
failed 0x6890000, check input refclk and power supply
[ 0.728172] phy phy-fe8c0000.phy.4: phy init failed --> -110
[ 0.728704] rockchip-dw-pcie: probe of 3c0800000.pcie failed with error -110
[ 0.745193] ALSA device list:
Thanks
-Anand
Thanks, Chukun
---
Chukun Pan (3):
arm64: dts: rockchip: Add regulator suffix to ROCK3 Model A
arm64: dts: rockchip: Rename pinctrl label of pcie2x1 on rock-3a
arm64: dts: rockchip: Add PCIe v3 nodes to rock-3a
.../boot/dts/rockchip/rk3568-rock-3a.dts | 36 ++++++++++++++-----
1 file changed, 27 insertions(+), 9 deletions(-)
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
