On 25.09.2022 22:44, Matti Lehtimäki wrote: > Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T530) wifi tablet > based on the apq8026 platform. > > Currently supported are accelerometer sensor, hall sensor, > internal storage, physical buttons (power & volume), screen > (based on simple-framebuffer set up by the bootloader), sdcard, > touchscreen and USB. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx> > --- > Changes in v5: > - Rename pm8226-regulators node to fix issue reported by make dtbs_check > > Changes in v4: > - Move delete-node to memory-region > - Move usb-switch node to blsp_i2c4 > > Changes in v3: > - Fix sdhc_2 bus width > - Reorder includes > > Changes in v2: > - Change codename to matisse-wifi > - Remove msm-id, not needed when lk2nd is used > - Remove unused labels from reserved memory regions > - Rename muic node > --- > arch/arm/boot/dts/Makefile | 1 + > .../dts/qcom-apq8026-samsung-matisse-wifi.dts | 453 ++++++++++++++++++ > 2 files changed, 454 insertions(+) > create mode 100644 arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 05d8aef6e5d2..69f6bbcf90c6 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1027,6 +1027,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \ > qcom-apq8016-sbc.dtb \ > qcom-apq8026-asus-sparrow.dtb \ > qcom-apq8026-lg-lenok.dtb \ > + qcom-apq8026-samsung-matisse-wifi.dtb \ > qcom-apq8060-dragonboard.dtb \ > qcom-apq8064-cm-qs600.dtb \ > qcom-apq8064-ifc6410.dtb \ > diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts > new file mode 100644 > index 000000000000..3029bc566832 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts > @@ -0,0 +1,453 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2022, Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx> > + */ > + > +/dts-v1/; > + > +#include <dt-bindings/input/input.h> > +#include "qcom-msm8226.dtsi" > +#include "qcom-pm8226.dtsi" > + > +/ { > + model = "Samsung Galaxy Tab 4 10.1"; > + compatible = "samsung,matisse-wifi", "qcom,apq8026"; > + chassis-type = "tablet"; > + > + aliases { > + mmc0 = &sdhc_1; /* SDC1 eMMC slot */ > + mmc1 = &sdhc_2; /* SDC2 SD card slot */ > + display0 = &framebuffer0; > + }; > + > + chosen { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + stdout-path = "display0"; > + > + framebuffer0: framebuffer@3200000 { > + compatible = "simple-framebuffer"; > + reg = <0x3200000 0x800000>; Addresses should be padded to 8 hex digits. > + width = <1280>; > + height = <800>; > + stride = <(1280 * 3)>; > + format = "r8g8b8"; > + }; > + }; > + > + gpio-hall-sensor { > + compatible = "gpio-keys"; > + > + event-hall-sensor { > + label = "Hall Effect Sensor"; > + gpios = <&tlmm 110 GPIO_ACTIVE_HIGH>; > + interrupts = <&tlmm 110 IRQ_TYPE_EDGE_FALLING>; > + linux,input-type = <EV_SW>; > + linux,code = <SW_LID>; > + debounce-interval = <15>; > + wakeup-source; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + autorepeat; > + > + key-home { > + label = "Home"; > + gpios = <&tlmm 108 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_HOMEPAGE>; > + debounce-interval = <15>; > + }; > + > + key-volume-down { > + label = "Volume Down"; > + gpios = <&tlmm 107 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_VOLUMEDOWN>; > + debounce-interval = <15>; > + }; > + > + key-volume-up { > + label = "Volume Up"; > + gpios = <&tlmm 106 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_VOLUMEUP>; > + debounce-interval = <15>; > + }; > + }; > + > + reg_tsp_1p8v: regulator-tsp-1p8v { > + compatible = "regulator-fixed"; > + regulator-name = "tsp_1p8v"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + > + gpio = <&tlmm 31 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&tsp_en_default_state>; > + }; > + > + reg_tsp_3p3v: regulator-tsp-3p3v { > + compatible = "regulator-fixed"; > + regulator-name = "tsp_3p3v"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 73 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&tsp_en1_default_state>; > + }; > + > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + framebuffer@3200000 { > + reg = <0x3200000 0x800000>; Ditto > + no-map; > + }; > + > + mpss@8400000 { > + reg = <0x08400000 0x1f00000>; > + no-map; > + }; > + > + mba@a300000 { > + reg = <0x0a300000 0x100000>; > + no-map; > + }; > + > + reserved@cb00000 { > + reg = <0x0cb00000 0x700000>; > + no-map; > + }; > + > + wcnss@d200000 { > + reg = <0x0d200000 0x700000>; > + no-map; > + }; > + > + adsp@d900000 { > + reg = <0x0d900000 0x1800000>; > + no-map; > + }; > + > + venus@f100000 { > + reg = <0x0f100000 0x500000>; > + no-map; > + }; > + > + /delete-node/ smem@3000000; > + smem_region: smem@fa00000 { > + reg = <0xfa00000 0x100000>; > + no-map; > + }; > + > + reserved@fb00000 { > + reg = <0x0fb00000 0x260000>; > + no-map; > + }; > + > + rfsa@fd60000 { > + reg = <0x0fd60000 0x20000>; > + no-map; > + }; > + > + rmtfs@fd80000 { > + compatible = "qcom,rmtfs-mem"; > + reg = <0x0fd80000 0x180000>; > + no-map; > + > + qcom,client-id = <1>; > + }; > + }; > +}; > + > +&blsp1_i2c2 { > + status = "okay"; > + > + accelerometer@1d { > + compatible = "st,lis2hh12"; > + reg = <0x1d>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <54 IRQ_TYPE_LEVEL_HIGH>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&accel_int_default_state>; > + > + st,drdy-int-pin = <1>; > + > + vdd-supply = <&pm8226_l19>; > + vddio-supply = <&pm8226_lvs1>; > + }; > +}; > + > +&blsp1_i2c4 { > + status = "okay"; > + > + muic: usb-switch@25 { > + compatible = "siliconmitus,sm5502-muic"; > + reg = <0x25>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <67 IRQ_TYPE_EDGE_FALLING>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&muic_int_default_state>; > + }; > +}; > + > +&blsp1_i2c5 { > + status = "okay"; > + > + touchscreen@4a { > + compatible = "atmel,maxtouch"; > + reg = <0x4a>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <17 IRQ_TYPE_LEVEL_LOW>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&tsp_int_rst_default_state>; > + > + reset-gpios = <&pm8226_gpios 6 GPIO_ACTIVE_LOW>; > + > + vdd-supply = <®_tsp_1p8v>; > + vdda-supply = <®_tsp_3p3v>; > + }; > +}; > + > +&rpm_requests { > + regulators { > + compatible = "qcom,rpm-pm8226-regulators"; > + > + pm8226_s3: s3 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1300000>; > + }; > + > + pm8226_s4: s4 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8226_s5: s5 { > + regulator-min-microvolt = <1150000>; > + regulator-max-microvolt = <1150000>; > + }; > + > + pm8226_l1: l1 { > + regulator-min-microvolt = <1225000>; > + regulator-max-microvolt = <1225000>; > + }; > + > + pm8226_l2: l2 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + }; > + > + pm8226_l3: l3 { > + regulator-min-microvolt = <750000>; > + regulator-max-microvolt = <1337500>; > + regulator-always-on; > + }; > + > + pm8226_l4: l4 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + }; > + > + pm8226_l5: l5 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + }; > + > + pm8226_l6: l6 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + }; > + > + pm8226_l7: l7 { > + regulator-min-microvolt = <1850000>; > + regulator-max-microvolt = <1850000>; > + }; > + > + pm8226_l8: l8 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + }; > + > + pm8226_l9: l9 { > + regulator-min-microvolt = <2050000>; > + regulator-max-microvolt = <2050000>; > + }; > + > + pm8226_l10: l10 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8226_l12: l12 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8226_l14: l14 { > + regulator-min-microvolt = <2750000>; > + regulator-max-microvolt = <2750000>; > + }; > + > + pm8226_l15: l15 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + pm8226_l16: l16 { > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3350000>; > + }; > + > + pm8226_l17: l17 { > + regulator-min-microvolt = <2950000>; > + regulator-max-microvolt = <2950000>; > + > + regulator-system-load = <200000>; > + regulator-allow-set-load; > + regulator-always-on; > + }; > + > + pm8226_l18: l18 { > + regulator-min-microvolt = <2950000>; > + regulator-max-microvolt = <2950000>; > + }; > + > + pm8226_l19: l19 { > + regulator-min-microvolt = <2850000>; > + regulator-max-microvolt = <3000000>; > + }; > + > + pm8226_l20: l20 { > + regulator-min-microvolt = <3075000>; > + regulator-max-microvolt = <3075000>; > + }; > + > + pm8226_l21: l21 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2950000>; > + }; > + > + pm8226_l22: l22 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3000000>; > + }; > + > + pm8226_l23: l23 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + pm8226_l24: l24 { > + regulator-min-microvolt = <1300000>; > + regulator-max-microvolt = <1350000>; > + }; > + > + pm8226_l25: l25 { > + regulator-min-microvolt = <1775000>; > + regulator-max-microvolt = <2125000>; > + }; > + > + pm8226_l26: l26 { > + regulator-min-microvolt = <1225000>; > + regulator-max-microvolt = <1300000>; > + }; > + > + pm8226_l27: l27 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8226_l28: l28 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2950000>; > + }; > + > + pm8226_lvs1: lvs1 {}; > + }; > +}; > + > +&sdhc_1 { > + status = "okay"; Status last, please. > + > + vmmc-supply = <&pm8226_l17>; > + vqmmc-supply = <&pm8226_l6>; > + > + bus-width = <8>; > + non-removable; > +}; > + > +&sdhc_2 { > + status = "okay"; Status last, please. > + > + vmmc-supply = <&pm8226_l18>; > + vqmmc-supply = <&pm8226_l21>; > + > + bus-width = <4>; > + cd-gpios = <&tlmm 38 GPIO_ACTIVE_LOW>; > +}; > + > +&tlmm { > + accel_int_default_state: accel-int-default-state { > + pins = "gpio54"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + muic_int_default_state: muic-int-default-state { > + pins = "gpio67"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + tsp_en_default_state: tsp-en-default-state { > + pins = "gpio31"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + tsp_en1_default_state: tsp-en1-default-state { > + pins = "gpio73"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + tsp_int_rst_default_state: tsp-int-rst-default-state { > + pins = "gpio17"; > + function = "gpio"; > + drive-strength = <10>; > + bias-pull-up; > + }; > +}; > + > +&usb { > + status = "okay"; > + extcon = <&muic>, <&muic>; Status last, please. Konrad > +}; > + > +&usb_hs_phy { > + extcon = <&muic>; > + v1p8-supply = <&pm8226_l10>; > + v3p3-supply = <&pm8226_l20>; > +};