On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: >On 19/09/2022 18:56, Guillaume Ranquet wrote: >> Add dpi support to enable the HDMI path. >> >> Signed-off-by: Guillaume Ranquet <granquet@xxxxxxxxxxxx> >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >> index 72049a530ae1..27f029ca760b 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >> .data = (void *)MTK_DPI }, >> { .compatible = "mediatek,mt8192-dpi", >> .data = (void *)MTK_DPI }, >> + { .compatible = "mediatek,mt8195-dpi", >> + .data = (void *)MTK_DPI }, > >It's compatible with the others. You don't need more compatibles. Hi Krzysztof, It's a bit confusing, because this compatible is used in both mtk_drm_drv.c and in mtk_dpi.c Albeit it's entirely the same thing regarding the mtk_drm_drv module, it's pretty different regarding the mtk_dpi module. Thx, Guillaume. > >Best regards, >Krzysztof >