On Mon, Sep 26, 2022 at 5:16 PM Marek Vasut <marex@xxxxxxx> wrote:
>
> Split st,stm32-fmc2-ebi.yaml specific properties into st,stm32-fmc2-ebi-props.yaml ,
> split memory-controller bus peripheral properties into mc-peripheral-props.yaml ,
> reference the st,stm32-fmc2-ebi-props.yaml in mc-peripheral-props.yaml and
> reference the mc-peripheral-props.yaml in micrel,ks8851.yaml .
>
> This way, the FMC2 controller properties in Micrel KSZ8851MLL ethernet
> controller node can be properly validated.
>
> Fixes the following warning:
>
> "
> arch/arm/boot/dts/stm32mp153c-dhcor-drc-compact.dtb: ethernet@1,0: Unevaluated properties are not allowed ('bank-width', 'st,fmc2-ebi-cs-mux-enable', 'st,fmc2-ebi-cs-transaction-type', 'st,fmc2-ebi-cs-buswidth', 'st,fmc2-ebi-cs-address-setup-ns', 'st,fmc2-ebi-cs-address-hold-ns', 'st,fmc2-ebi-cs-bus-turnaround-ns', 'st,fmc2-ebi-cs-data-setup-ns', 'st,fmc2-ebi-cs-data-hold-ns', 'st,fmc2-ebi-cs-write-address-setup-ns', 'st,fmc2-ebi-cs-write-address-hold-ns', 'st,fmc2-ebi-cs-write-bus-turnaround-ns', 'st,fmc2-ebi-cs-write-data-setup-ns', 'st,fmc2-ebi-cs-write-data-hold-ns' were unexpected)
> "
>
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
> ---
> Cc: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>
> Cc: Christophe Kerello <christophe.kerello@xxxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> ---
> .../mc-peripheral-props.yaml | 36 +++++
> .../st,stm32-fmc2-ebi-props.yaml | 144 ++++++++++++++++++
> .../memory-controllers/st,stm32-fmc2-ebi.yaml | 137 -----------------
> .../bindings/net/micrel,ks8851.yaml | 1 +
> 4 files changed, 181 insertions(+), 137 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/memory-controllers/mc-peripheral-props.yaml
> create mode 100644 Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi-props.yaml
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/mc-peripheral-props.yaml b/Documentation/devicetree/bindings/memory-controllers/mc-peripheral-props.yaml
> new file mode 100644
> index 0000000000000..442744a9b711d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/mc-peripheral-props.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/memory-controllers/mc-peripheral-props.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Peripheral-specific properties for a Memory Controller bus.
> +
> +description:
> + Many MC controllers need to add properties to peripheral devices.
Memory Controller controllers?
> + They could be common properties like reg or they could be controller
> + specific like delay in clock or data lines, etc. These properties need
> + to be defined in the peripheral node because they are per-peripheral
> + and there can be multiple peripherals attached to a controller. All
> + those properties are listed here. The controller specific properties
> + should go in their own separate schema that should be referenced
> + from here.
> +
> +maintainers:
> + - Marek Vasut <marex@xxxxxxx>
> +
> +properties:
> + reg:
> + description: Bank number, base address and size of the device.
> +
> + bank-width:
> + description: Bank width of the device, in bytes.
This needs a type and constraints (enum: [ 1, 2, 4 ]).
Other than that,
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
(I'm assuming Krzysztof takes this)
