On 22/09/2022 10:04, Krzysztof Kozlowski wrote:
On 15/09/2022 15:37, Dmitry Baryshkov wrote:
Move properties common to all MDSS DT nodes to the mdss-common.yaml.
This extends qcom,msm8998-mdss schema to allow interconnect nodes, which
will be added later, once msm8998 gains interconnect support.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
(...)
- "#interrupt-cells":
- const: 1
-
iommus:
- items:
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port1
-
- ranges: true
+ maxItems: 2
interconnects:
- items:
- - description: Interconnect path from mdp0 port to the data bus
- - description: Interconnect path from mdp1 port to the data bus
+ maxItems: 2
I think this is not equivalent now, because you have in total minItems:1
and maxItems:2, while in past minItems was 2.
This means that I should have minItems:2, maxItems:2, which, if I got it
right, is frowned upon. Let me doublecheck though if it works as expected.
The same might apply to iommus. clocks look good.
--
With best wishes
Dmitry
