On 22/09/2022 09:50, Dmitry Baryshkov wrote: > On Thu, 22 Sept 2022 at 10:02, Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 15/09/2022 15:37, Dmitry Baryshkov wrote: >>> Move properties common to all DPU DT nodes to the dpu-common.yaml. >>> >>> Note, this removes description of individual DPU port@ nodes. However >>> such definitions add no additional value. The reg values do not >>> correspond to hardware INTF indices. The driver discovers and binds >>> these ports not paying any care for the order of these items. Thus just >>> leave the reference to graph.yaml#/properties/ports and the description. >> >> This is okay, but you loose required:ports@[01]. > > This is fine for me. The ports do not have 1:1 correspondence to > intfs. Usually platforms add ports as new sinks are added. For example > a platform can start with a single DSI node and later get second DSI, > DP, eDP, etc. as they are receiving support/required by end-user > devices. Then at least port@0 would be required. Node without ports does not look correct. Best regards, Krzysztof