On Sat, Sep 17, 2022 at 11:14 AM Jean-Jacques Hiblot <jjhiblot@xxxxxxxxxxxxxxx> wrote: > > This information might be useful for more than only deriving the led's ... > + if (fwnode_property_present(init_data->fwnode, "color")) > + fwnode_property_read_u32(init_data->fwnode, "color", > + &led_cdev->color); Is it already described in the schema? ... > unsigned int brightness; > unsigned int max_brightness; > + unsigned int color; The above two are exposed via sysfs, do you need to expose a new one as well? (Just a question, I am not taking any side here, want to hear explanation of the either choice) -- With Best Regards, Andy Shevchenko