Re: [PATCH] dt-bindings: mips: add CPU bindings for MIPS architecture

[Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>]

Hi Rob,

On Fri, Sep 16, 2022 at 9:34 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Thu, Sep 15, 2022 at 07:55:14AM +0200, Sergio Paracuellos wrote:
> > Add the yaml binding for available CPUs in MIPS architecture.
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> > ---
> >  .../devicetree/bindings/mips/cpus.yaml        | 66 +++++++++++++++++++
> >  1 file changed, 66 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mips/cpus.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mips/cpus.yaml b/Documentation/devicetree/bindings/mips/cpus.yaml
> > new file mode 100644
> > index 000000000000..4277adc65ed6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mips/cpus.yaml
> > @@ -0,0 +1,66 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mips/cpus.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MIPS CPUs bindings
> > +
> > +maintainers:
> > +  - Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> > +
> > +description: |+
> > +  The device tree allows to describe the layout of CPUs in a system through
> > +  the "cpus" node, which in turn contains a number of subnodes (ie "cpu")
> > +  defining properties for every cpu.
> > +
> > +properties:
> > +  reg:
> > +    maxItems: 1
> > +
> > +  compatible:
> > +    enum:
> > +      - brcm,bmips3300
> > +      - brcm,bmips4350
> > +      - brcm,bmips4380
> > +      - brcm,bmips5000
> > +      - brcm,bmips5200
>
> You need to remove bindings/mips/brcm/brcm,bmips.txt. But it also
> defines a property which needs to be added.

I have addressed this in v2:
  https://lore.kernel.org/linux-devicetree/20220917041136.526446-1-sergio.paracuellos@xxxxxxxxx/T/#u

>
> I didn't check the rest for existing documentation...

The rest of compatible strings for cpu's that I am listing here seems
to not contain associated txt bindings description, so I guess if
anything extra is needed / required can be added afterwards?

Thanks,
   Sergio Paracuellos

>
> > +      - ingenic,xburst-mxu1.0
> > +      - ingenic,xburst-fpu1.0-mxu1.1
> > +      - ingenic,xburst-fpu2.0-mxu2.0
> > +      - loongson,gs264
> > +      - mips,mips1004Kc
> > +      - mips,m14Kc
> > +      - mips,mips24KEc
> > +      - mips,mips4KEc
> > +      - mips,mips74Kc
> > +      - mips,mips24Kc
> > +      - mti,mips24KEc
> > +      - mti,mips14KEc
> > +      - mti,mips14Kc
> > +      - mti,interaptiv
> > +
> > +required:
> > +  - compatible
> > +
> > +additionalProperties: true
> > +
> > +examples:
> > +  - |
> > +    cpus {
> > +      #size-cells = <0>;
> > +      #address-cells = <1>;
> > +
> > +      cpu@0 {
> > +        device_type = "cpu";
> > +        compatible = "mips,mips1004Kc";
> > +        reg = <0>;
> > +      };
> > +
> > +      cpu@1 {
> > +        device_type = "cpu";
> > +        compatible = "mips,mips1004Kc";
> > +        reg = <1>;
> > +      };
> > +    };
> > +
> > --
> > 2.25.1
> >
> >