Hi Sakari, Thank you for the review. On Fri, Sep 16, 2022 at 12:52 PM Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On Tue, Sep 13, 2022 at 05:02:24PM +0100, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Convert the simple OV5645 Device Tree binding to json-schema. <snip> > > + $ref: /schemas/media/video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + clock-lanes: > > + const: 0 > > + > > + bus-type: > > + const: 4 > > Please drop the two, they provide no information to the driver that already > knows this. (Unless of course, the driver supports other bus types these > bindings do not document. Some OV sensors do.) clock-lanes needs to go in > any case, and data-lanes are dependent on bus-type being 4 I presume. > Agreed, I will drop the above two and send a v2. > bus-type is also not present in the example. > Ahh, I missed that. Cheers, Prabhakar
