On 16/09/2022 11:17, Viorel Suman wrote: > On 22-09-16 10:38:30, Krzysztof Kozlowski wrote: >> On 15/09/2022 19:18, Viorel Suman (OSS) wrote: >>> From: Viorel Suman <viorel.suman@xxxxxxx> >>> >>> Sync defines with the latest available SCFW kit version 1.13.0, >>> may be found at the address below: >>> >>> https://www.nxp.com/webapp/Download?colCode=L5.15.32_2.0.0_SCFWKIT-1.13.0&appType=license >>> >>> Signed-off-by: Viorel Suman <viorel.suman@xxxxxxx> >>> --- >>> include/dt-bindings/firmware/imx/rsrc.h | 299 ++++++++++++++++-------- >>> 1 file changed, 203 insertions(+), 96 deletions(-) >>> >>> diff --git a/include/dt-bindings/firmware/imx/rsrc.h b/include/dt-bindings/firmware/imx/rsrc.h >>> index 43885056557c..a4c68f394986 100644 >>> --- a/include/dt-bindings/firmware/imx/rsrc.h >>> +++ b/include/dt-bindings/firmware/imx/rsrc.h >>> @@ -13,34 +13,38 @@ >>> * never be changed or removed (only added to at the end of the list). >>> */ >>> >>> -#define IMX_SC_R_A53 0 >>> -#define IMX_SC_R_A53_0 1 >> >> You cannot change binding constants... Aren't you breaking all possible >> boards and users? > > Hi Krzysztof, > > There is a backward compatibility section added in the end of the patch, > it follows the same approach as in SCFW kit v1.13.0: > > +/* > + * Compatibility defines for sc_rsrc_t > + */ > +#define IMX_SC_R_A35 IMX_SC_R_AP_2 Then it looks fine, except someone would need to compare/test the numbers... Best regards, Krzysztof
