On 10/10/2014 08:14 PM, Bjorn Andersson wrote: > On Tue, Sep 2, 2014 at 8:40 AM, Georgi Djakov <gdjakov@xxxxxxxxxx> wrote: >> Enable support for the two SD host controllers on the APQ8084 platform >> by adding the required nodes to the DT files. >> On the IFC6540 board, the first controller is connected to the onboard >> eMMC and the second is connected to a micro-SD card slot. >> >> Signed-off-by: Georgi Djakov <gdjakov@xxxxxxxxxx> > > Hi Georgi, > > This looks sane, but... > >> --- >> arch/arm/boot/dts/qcom-apq8084-ifc6540.dts | 11 +++++++++++ >> arch/arm/boot/dts/qcom-apq8084.dtsi | 23 +++++++++++++++++++++++ >> 2 files changed, 34 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts >> index e41cb8a..c9ff108 100644 >> --- a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts >> +++ b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts > [..] >> + sdhci@f98a4900 { >> + cd-gpios = <&tlmm 122 GPIO_ACTIVE_LOW>; >> + bus-width = <4>; > > ...why do you add this node and leave it disabled in the dts? > Hi Bjorn, Currently only the eMMC is functional on this board, so now we have just the board specific configuration under this node. More patches are forthcoming. BR, Georgi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html