Re: [PATCH v2] dt-bindings: phy: renesas,rcar-gen2-usb-phy: Convert to json-schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15/09/2022 12:12, Geert Uytterhoeven wrote:
> Hi Krzysztof,
> 
> On Thu, Sep 15, 2022 at 10:35 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:>
>> On Wed, 14 Sep 2022 16:17:37 +0200, Geert Uytterhoeven wrote:
>>> Convert the Renesas R-Car Gen2 USB PHY Device Tree binding documentation
>>> to json-schema.
>>>
>>> Add missing properties.
>>> Rename the device node from "usb-phy" to "usb-phy-controller", as it
>>> does not represent a USB PHY itself, and thus does not have a
>>> "#phy-cells" property.
>>> Rename the child nodes from "usb-channel" to "usb-phy", as these do
>>> represent USB PHYs.
>>> Drop the second example, as it doesn't add any value.
>>>
>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>>> ---
>>> v2:
>>>   - Rename nodes to fix "'#phy-cells' is a required property".
>>>
>>> This is the final conversion to json-schema of DT bindings for Renesas
>>> ARM SoCs, hurray!
>>>
>>> Note that there are still a few plain text bindings left for Renesas IP
>>> cores that are present on non-Renesas SoCs (nbpfaxi and usdhi6rol0).
>>> ---
>>>  .../devicetree/bindings/phy/rcar-gen2-phy.txt | 112 ----------------
>>>  .../phy/renesas,rcar-gen2-usb-phy.yaml        | 123 ++++++++++++++++++
>>>  2 files changed, 123 insertions(+), 112 deletions(-)
>>>  delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt
>>>  create mode 100644 Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.yaml
>>>
>>
>> Running 'make dtbs_check' with the schema in this patch gives the
>> following warnings. Consider if they are expected or the schema is
>> incorrect. These may not be new warnings.
> 
> These should be fixed by the DTS counterpart
> "[PATCH] ARM: dts: renesas: Fix USB PHY device and child node names"
> https://lore.kernel.org/all/6442b4042e26537abc8632c4772f8201685f1f1f.1663165098.git.geert+renesas@xxxxxxxxx/>
> 
> In hindsight, I should have cross-linked the patches in both
> directions, not just in one direction. Sorry for that.

No worries. Thanks for fixing it and error can be ignored.


Best regards,
Krzysztof



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux