Hello Russell, On 14/09/22 21:34, Russell King (Oracle) wrote: > On Wed, Sep 14, 2022 at 03:20:51PM +0530, Siddharth Vadapalli wrote: >> +#define MAC2MAC_MR_ADV_ABILITY_BASE (BIT(15) | BIT(0)) >> +#define MAC2MAC_MR_ADV_ABILITY_FULLDUPLEX BIT(12) >> +#define MAC2MAC_MR_ADV_ABILITY_1G BIT(11) >> +#define MAC2MAC_MR_ADV_ABILITY_100M BIT(10) >> +#define MAC2PHY_MR_ADV_ABILITY BIT(0) > > In addition to my other comments, this looks like a reimplementation of > the LPA_SGMII* constants found in include/uapi/linux/mii.h I was not aware of this. Thank you for letting me know. I will use the existing constants in the v2 series. Regards, Siddharth.
