On 09/13/22 18:07, Doug Berger wrote: > On 9/13/2022 4:34 PM, Matthew Wilcox wrote: > > On Tue, Sep 13, 2022 at 12:54:50PM -0700, Doug Berger wrote: > > > With gigantic pages it may not be true that struct page structures > > > are contiguous across the entire gigantic page. The mem_map_offset > > > function is used here in place of direct pointer arithmetic to > > > correct for this. > > > > We're just eliminating mem_map_offset(). Please use nth_page() > > instead.That's good to know. I will include that in v2. Thanks Doug and Matthew. I will take a closer look at this series soon. It seems like this patch is a fix independent of the series. If so, I would suggest sending separate to make it easy for backports to stable. -- Mike Kravetz