On Wed, Sep 14, 2022 at 03:20:49PM +0530, Siddharth Vadapalli wrote: > Add function am65_cpsw_nuss_mac_enable_link() to invoke > am65_cpsw_enable_phy(), cpsw_ale_control_set(), am65_cpsw_qos_link_up() > and netif_tx_wake_all_queues() to prevent duplicate code. The above > set of function calls are currently invoked by the > am65_cpsw_nuss_mac_link_up() function. In a later patch in this series > meant for adding fixed-link support, even the am65_cpsw_nuss_mac_config() > function will invoke the same set of functions. I don't think you will need this patch once you've debugged why mac_link_up() doesn't get called for a fixed link (it should be called.) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!