Hi CK, Thanks for the reviews. On Mon, 2022-09-12 at 11:40 +0800, CK Hu wrote: > Hi, Jason: > > On Mon, 2022-09-12 at 09:30 +0800, Jason-JH.Lin wrote: > > Add lut_bits in gamma driver data for each SoC and adjust the usage > > of lut_bits in mtk_drm_gamma_set_common(). > > > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx> > > --- > > drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 36 ++++++++++++++++--- > > -- > > -- > > 1 file changed, 25 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c > > b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c > > index 0a1022032b71..be82d15a5204 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c > > +++ b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c > > @@ -25,11 +25,14 @@ > > > > #define LUT_10BIT_MASK 0x03ff > > #define LUT_SIZE_DEFAULT 512 /* for setting > > gamma lut from AAL */ > > +#define LUT_BITS_DEFAULT 10 > > +#define LUT_INPUT_BITS 16 /* input lut > > bit from application */ > > I think we should use drm_color_lut_extract() to let the input bits > transparent. So add one patch to use drm_color_lut_extract(), and > then > apply this patch. > > Regards, > CK OK, I'll separate it to 2 patches, 1 is using drm_color_lut_extract() to handle with input lut data and the other is adding gamma support lut_bits and shift_bits. Regards, Jason-JH.Lin
